Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval eager_loading when ready #986

Merged
merged 3 commits into from
Oct 30, 2019
Merged

eval eager_loading when ready #986

merged 3 commits into from
Oct 30, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

Fixes #984 - delays (reevaluates) Css and Scripts at the moment when the server is ready instead of doing so during initialization.

This should allow us to handle both (1) app.run_server and (2) gunicorn / multi-page apps correctly.

@Marc-Andre-Rivet
Copy link
Contributor Author

Build failures seem related to percy failures.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Marc-André Rivet added 2 commits October 29, 2019 19:22
@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 3c5900f into dev Oct 30, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the eager-flag-fix branch October 30, 2019 00:53
@wbrgss
Copy link
Contributor

wbrgss commented Oct 30, 2019

well, it appears to solve my problem 😌
nice work @Marc-Andre-Rivet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _force_eager_loading depends on import/instantiation order
3 participants