Skip to content

Commit

Permalink
Removing source maps from dependencies (#283)
Browse files Browse the repository at this point in the history
  • Loading branch information
HammadTheOne committed Nov 1, 2021
1 parent c4ab3dc commit fc65a0a
Show file tree
Hide file tree
Showing 19 changed files with 4 additions and 134 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Changed
- Unified the core Dash packages (dash, dashCoreComponents, dashHtmlComponents, dashTable) for streamlined maintenance and accessibility. The namespaces of these packages will be combined under the `dash` namespace, and all artifacts from the ancillary dash packages will be included with Dash for R. [#243](https://github.com/plotly/dashr/pull/243)
- Removed source-mapping from the `master` branch on Github and CRAN release of Dash R. Source-mapping is still available in the `dev` branch for contributors. [#282](https://github.com/plotly/dashR/pull/282)

### Fixed
- Minor fix for favicon issue continued from [#240](https://github.com/plotly/dashr/pull/240) (for more details, see [#243](https://github.com/plotly/dashR/pull/243#issuecomment-842813526)).
Expand Down
120 changes: 3 additions & 117 deletions R/internal.R
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,6 @@
package = "dash",
all_files = FALSE),
class = "html_dependency"),
`dash-renderer-map-dev` = structure(list(name = "dash-renderer",
version = "1.8.3",
src = list(href = "https://unpkg.com/dash-renderer@1.8.3",
file = "lib/dash-renderer@1.8.3"),
meta = NULL,
script = "dash-renderer/dash_renderer.dev.js.map",
stylesheet = NULL,
head = NULL,
attachment = NULL,
package = "dash",
all_files = FALSE),
class = "html_dependency"),
`dash-renderer-prod` = structure(list(name = "dash-renderer",
version = "1.8.3",
src = list(href = "https://unpkg.com/dash-renderer@1.8.3",
Expand All @@ -71,18 +59,6 @@
package = "dash",
all_files = FALSE),
class = "html_dependency"),
`dash-renderer-map-prod` = structure(list(name = "dash-renderer",
version = "1.8.3",
src = list(href = "https://unpkg.com/dash-renderer@1.8.3",
file = "lib/dash-renderer@1.8.3"),
meta = NULL,
script = "dash-renderer/dash_renderer.min.js.map",
stylesheet = NULL,
head = NULL,
attachment = NULL,
package = "dash",
all_files = FALSE),
class = "html_dependency"),
`prop-types-dev` = structure(list(name = "prop-types",
version = "15.7.2",
src = list(href = "https://unpkg.com/prop-types@15.7.2",
Expand Down Expand Up @@ -157,72 +133,18 @@ all_files = FALSE, async = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-datepicker.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-dropdown.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-graph.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-highlight.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-markdown.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-slider.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-upload.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/dash_core_components.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/dash_core_components.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/dash_core_components-shared.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/dash_core_components-shared.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/plotly.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, async = 'eager'), class = "html_dependency"),
Expand All @@ -231,13 +153,7 @@ version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-plotlyjs.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, async = 'lazy'), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dcc/async-plotlyjs.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
all_files = FALSE, async = 'lazy'), class = "html_dependency"))
return(deps_metadata)
}

Expand All @@ -248,13 +164,7 @@ version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'html/dash_html_components.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE), class = "html_dependency"),
`dash_html_components` = structure(list(name = "dash_html_components",
version = "2.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'html/dash_html_components.min.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
all_files = FALSE), class = "html_dependency"))
return(deps_metadata)
}

Expand Down Expand Up @@ -298,33 +208,9 @@ all_files = FALSE, async = TRUE), class = "html_dependency"),
`dash_table` = structure(list(name = "dash_table",
version = "5.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_table/async-export.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_table` = structure(list(name = "dash_table",
version = "5.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_table/async-table.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_table` = structure(list(name = "dash_table",
version = "5.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_table/async-highlight.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_table` = structure(list(name = "dash_table",
version = "5.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_table/bundle.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE), class = "html_dependency"),
`dash_table` = structure(list(name = "dash_table",
version = "5.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_table/bundle.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dash",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"))
all_files = FALSE), class = "html_dependency"))
return(deps_metadata)
}

Expand Down
1 change: 0 additions & 1 deletion inst/deps/dash_table/async-export.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dash_table/async-highlight.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dash_table/async-table.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dash_table/bundle.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dash_table/demo.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-datepicker.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-dropdown.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-graph.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-highlight.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-markdown.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-slider.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/async-upload.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/dash_core_components-shared.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/dcc/dash_core_components.js.map

This file was deleted.

1 change: 0 additions & 1 deletion inst/deps/html/dash_html_components.min.js.map

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit fc65a0a

Please sign in to comment.