Relocate metadata fixup logic from config.yml to R script #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
reviewed
Aug 3, 2020
HammadTheOne
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
This looks good and makes sense logically. I can see why this would be nice to clean up the Python script here.
Other than the missing newline it LGTM 💃 . Feel free to tag me on https://github.com/plotly/dash/tree/212-untangle-dashr-build and I can take a look at how CI handles this with changes to the Python version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/plotly/dash-core/issues/212, this PR will clean up the
config.ymlscript and attempt to resolve friction during release time by loosening the requirement for R package versions.We will no longer validate the version number for core packages, but merely enforce that the development package version in R is greater than or equal to the previously released version.