Add support for 'subplots' from plot_ly and ggplotly in DashR #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @sacul-git in #83, DashR would fail to properly mutate
plot_ly
andggplotly
objects constructed using thesubplots
function from theplotly
R package.The changes proposed in this PR change the logic for mutating the layout in
encode_plotly
; now, the function willlist
; if it is, thenplotly
; if they do, thenx
; if it does, thenx
matchvisdat
ordata
; if they do, mutatedashR/R/utils.R
Lines 579 to 582 in 5264c7c