Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth redirection broken in web app #260

Closed
n-riesco opened this issue Nov 17, 2017 · 2 comments · Fixed by #453
Closed

oauth redirection broken in web app #260

n-riesco opened this issue Nov 17, 2017 · 2 comments · Fixed by #453
Assignees
@tarzzz
Labels
bug

Comments

@n-riesco
Copy link
Contributor

After the user is authorised and popup window closes, the main window remains in login page.

peek 2017-11-17 20-57
@n-riesco n-riesco mentioned this issue Dec 7, 2017
Closed
@n-riesco n-riesco assigned n-riesco and tarzzz and unassigned n-riesco Dec 7, 2017
@n-riesco n-riesco mentioned this issue Dec 8, 2017
Merged
1 task
@tarzzz
Copy link
Contributor

tarzzz commented Dec 8, 2017

@n-riesco Need some info regarding this:

  • What is the setting SSL_ENABLED here? Or PLOTLY_CONNECTOR_SSL_ENABLED ..
  • Can you please send the cookies set on localhost ..

For localhost, I would recommend starting docker container with PLOTLY_CONNECTOR_SSL_ENABLED=false and see if login works.

In any case, this is not a blocker for on-prem, because login works on-prem on the latest build I tested today.

@scjody
Copy link
Contributor

scjody commented Dec 8, 2017

Agreed: as long as login works in On-Prem this isn't a release blocker for On-Prem.

@tarzzz If you become aware of any login issues that affect On-Prem, please log an issue in the 2.3.0 milestone of streambed (and also here if that's appropriate).

n-riesco added a commit that referenced this issue Jun 5, 2018
@n-riesco
oauth: fix authorisation in the web app
f362921 
* Ensure the cookie db-connector-user is also passed to HTTP
  connections.

* Trigger the reload of the web app when the authorisation popup is
  closed.

Fixes #260
@n-riesco n-riesco mentioned this issue Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarzzz tarzzz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable nodeintegration plotly/falcon
3 participants
@scjody @tarzzz @n-riesco