Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: upgrade dependencies to resolve multiple CVEs #2

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

devinturner
Copy link

@antoinerg
Copy link

I forget why we have our fork of Harbor. Do you happen to remember?

I'm asking because it's too time-consuming to review/validate changes made here without any CI. It would be nicer to have this work land upstream and have the maintainers review it.

Anyway, in the interest of time, I'm OK with approving this and catching potential regressions in dek-deployment via e2e tests 🚀

@devinturner
Copy link
Author

devinturner commented Mar 26, 2024

I forget why we have our fork of Harbor. Do you happen to remember?

I'm asking because it's too time-consuming to review/validate changes made here without any CI. It would be nicer to have this work land upstream and have the maintainers review it.

Anyway, in the interest of time, I'm OK with approving this and catching potential regressions in dek-deployment via e2e tests 🚀

Agreed. We forked it because it had vulnerabilities and was not really being maintained a few releases ago. I will be putting forward some changes to the upstream and see if we can get it back into a maintainable state, and we can get some CI jobs in place as well.

@devinturner devinturner merged commit b76952a into 5.3-sp-release Mar 26, 2024
@antoinerg
Copy link

@devinturner it looks like their Helm chart is under more active development. Therefore, I think we should move away from their operator altogether since we only manage one instance anyway.

@antoinerg antoinerg deleted the sec-upgrade-harbor-operator branch March 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants