Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add 2.10.x to the known constraints #3

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: add 2.10.x to the known constraints #3

merged 2 commits into from
Mar 28, 2024

Conversation

devinturner
Copy link

I missed this earlier. It allows the admission webhook to allow for the cluster to spin up the v2.10.x images.

@devinturner
Copy link
Author

I was able to get the cluster tests to work against a k3d cluster:

go generate ./...
kubectl apply --server-side=true --force-conflicts -f config/crd/bases
customresourcedefinition.apiextensions.k8s.io/chartmuseums.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/cores.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/exporters.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/harborclusters.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/harborconfigurations.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/harbors.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/harborserverconfigurations.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/jobservices.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/notaryservers.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/notarysigners.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/portals.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/pullsecretbindings.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/registries.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/registrycontrollers.goharbor.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/trivies.goharbor.io serverside-applied
go test \
        -p 1 -vet=off \
        ./... \
        -coverprofile cover.out
        github.com/plotly/harbor-operator               coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/apis/goharbor.io/v1alpha3     0.017s  coverage: 1.1% of statements
ok      github.com/plotly/harbor-operator/apis/goharbor.io/v1beta1      0.017s  coverage: 0.4% of statements
        github.com/plotly/harbor-operator/apis/meta/v1alpha1            coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers           coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor  99.380s coverage: 16.5% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/chartmuseum      24.179s coverage: 7.7% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/configuration            coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/core     26.785s coverage: 11.5% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/exporter         coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/harbor   0.049s  coverage: 6.7% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/harborcluster            coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/harborserverconfiguration                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test            coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/certificate                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/controllers                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/harbor-core                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/pods               coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/port-forward               coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/postgresql         coverage: 0.0% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/internal/test/redis              coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/jobservice       14.251s coverage: 10.7% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/namespace                coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/notaryserver     14.179s coverage: 9.7% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/notarysigner     20.783s coverage: 11.9% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/portal   24.172s coverage: 7.6% of statements
        github.com/plotly/harbor-operator/controllers/goharbor/pullsecretbinding                coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/registry 24.171s coverage: 10.5% of statements
ok      github.com/plotly/harbor-operator/controllers/goharbor/trivy    24.183s coverage: 8.8% of statements
        github.com/plotly/harbor-operator/pkg/builder           coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/cache         coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/common                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/database              coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/database/api          coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/harbor                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/storage               coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/controllers/storage/minio/apis/minio.min.io/v2            coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/gos               coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/cluster/k8s               coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/cluster/lcm       0.014s  coverage: 0.3% of statements
ok      github.com/plotly/harbor-operator/pkg/config    0.005s  coverage: 48.0% of statements
        github.com/plotly/harbor-operator/pkg/config/harbor             coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/config/template           coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/controller        0.065s  coverage: 6.1% of statements
        github.com/plotly/harbor-operator/pkg/controller/errors         coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/controller/internal/graph         coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/controller/mutation       0.021s  coverage: 1.9% of statements
        github.com/plotly/harbor-operator/pkg/convert           coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/event-filter/class        0.018s  coverage: 1.4% of statements
        github.com/plotly/harbor-operator/pkg/exit              coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/factories/application             coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/factories/logger          coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/factories/owner           coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/graph     0.013s  coverage: 80.0% of statements
ok      github.com/plotly/harbor-operator/pkg/image     0.014s  coverage: 94.1% of statements
        github.com/plotly/harbor-operator/pkg/manager           coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/registry/secret           coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/resources         coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/resources/checksum        0.029s  coverage: 4.6% of statements
ok      github.com/plotly/harbor-operator/pkg/resources/statuscheck     0.111s  coverage: 6.0% of statements
        github.com/plotly/harbor-operator/pkg/rest              coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/rest/model                coverage: 0.0% of statements
        github.com/plotly/harbor-operator/pkg/rest/v2           coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/rule      0.002s  coverage: 86.7% of statements
ok      github.com/plotly/harbor-operator/pkg/scheme    0.024s  coverage: 1.9% of statements
        github.com/plotly/harbor-operator/pkg/setup             coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/status    0.005s  coverage: 87.8% of statements
        github.com/plotly/harbor-operator/pkg/template          coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/tracing   0.014s  coverage: 72.3% of statements
?       github.com/plotly/harbor-operator/pkg/utils/consts      [no test files]
        github.com/plotly/harbor-operator/pkg/utils/strings             coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/pkg/version   0.004s  coverage: 95.6% of statements
        github.com/plotly/harbor-operator/webhooks/harborserverconfiguration            coverage: 0.0% of statements
ok      github.com/plotly/harbor-operator/webhooks/pod  0.015s  coverage: 1.0% of statements

@devinturner devinturner merged commit 33def05 into 5.3-sp-release Mar 28, 2024
agateaux pushed a commit that referenced this pull request May 2, 2024
@DeeAjayi @CoderTH @zlangi
Add Redis service account name to CRD (goharbor#1001)
ba4d731 
* upgrade controller-runtime version (goharbor#1034)

upgrade controller runtime version

Signed-off-by: coderth <coderth@outlook.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

* Add the missing github-cr proxy cache module (goharbor#1035)

Add the missing github proxy cache module

Signed-off-by: Zoltan Langi <zoltan.langi@gmail.com>
Co-authored-by: Zoltan Langi <zoltan.langi@gmail.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

* Add service account name to cr (#3)

* Included Service Account to Redis CR

Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>

* Revert deployment change

Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>

---------

Signed-off-by: coderth <coderth@outlook.com>
Signed-off-by: Dipo Ajayi <ajayidipo@ymail.com>
Signed-off-by: Zoltan Langi <zoltan.langi@gmail.com>
Signed-off-by: Oladipupo Ajayi <ajayidipo@ymail.com>
Co-authored-by: Noah Tang <51119718+CoderTH@users.noreply.github.com>
Co-authored-by: Zoltan <36501500+zlangi@users.noreply.github.com>
Co-authored-by: Zoltan Langi <zoltan.langi@gmail.com>
@agateaux agateaux deleted the fix-version-constraints branch May 8, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRONSOLO BRONSOLO Awaiting requested review from BRONSOLO

@obanby obanby Awaiting requested review from obanby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@devinturner