This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add optional argument for changing title of JupyterLab tab. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
litghost
changed the title
litghost
changed the title
Closed
alexcjohnson
reviewed
Apr 4, 2022
| @@ -149,6 +149,7 @@ def alive(): | |||
| def run_server( | |||
| self, | |||
| mode=None, width="100%", height=650, inline_exceptions=None, | |||
| jupyterlab_title="", | |||
There was a problem hiding this comment.
@litghost apologies for losing track of this PR for so long. If you're still interested in this, it's a great start, just two comments:
- we can call this kwarg just
title, since we already have examples of kwargs here (widthandheight) that apply only to one mode without including the mode in the name. - let's add this to the docstring below, and to the changelog.
If you've moved on and don't want to come back to this, no worries, I'll get this across the finish line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.