Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/build #368

Merged
merged 9 commits into from Dec 29, 2015
Merged

Fix/build #368

merged 9 commits into from Dec 29, 2015

Conversation

cpsievert
Copy link
Collaborator

This would require a major version bump (2.1) since we're changing the default for inheriting properties.

Let me know what you think @chriddyp @cldougl

@cpsievert
Copy link
Collaborator Author

I think this is ready to merge @chriddyp @cldougl, but I'll wait for +1 from someone since these are fairly drastic changes.

It's worth noting that plotly_build() is idempotent now (building a given plot more than once should be the same as building it once).

You can ignore diffs from the jitter tests above (they're showing up because they use random data -- I still need to fix that). The rest of the diffs look good to me (we don't need a filename for local plots and before we were incorrectly including an additional layout).

@cldougl
Copy link
Member

cldougl commented Dec 23, 2015

This all looks good to me (+1 for defaulting to inherit = FALSE )
💃 (as far as I'm concerned)

cpsievert added a commit that referenced this pull request Dec 29, 2015
@cpsievert cpsievert merged commit fdc5eb3 into master Dec 29, 2015
@cpsievert cpsievert deleted the fix/build branch January 28, 2016 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants