Merge pull request #4453 from plotly/script-order

enables loading locales before Plotly
plotly · Jan 2, 2020 · 4d88717 · 4d88717
2 parents 968054c + 00aadd7
commit 4d88717
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -65,6 +65,12 @@ register([
     require('./locale-en-us')
 ]);
 
+// locales that are present in the window should be loaded
+if(window.PlotlyLocales && Array.isArray(window.PlotlyLocales)) {
+    register(window.PlotlyLocales);
+    delete window.PlotlyLocales;
+}
+
 // plot icons
 exports.Icons = require('./fonts/ploticon');
 

diff --git a/tasks/util/wrap_locale.js b/tasks/util/wrap_locale.js
@@ -6,8 +6,8 @@ var intoStream = require('into-stream');
 
 var constants = require('./constants');
 
-var prefix = 'Plotly.register(';
-var suffix = ');';
+var prefix = 'var locale=';
+var suffix = ';if(typeof Plotly === \'undefined\') {window.PlotlyLocales = window.PlotlyLocales || []; window.PlotlyLocales.push(locale);} else {Plotly.register(locale);}';
 
 var moduleMarker = 'module.exports = ';