Merge pull request #2712 from plotly/surface-contours-fixes

A few surface contours fixes
plotly · Jun 11, 2018 · 69a1004 · 69a1004
2 parents 4981923 + 5ba1f95
commit 69a1004
Show file tree

Hide file tree

Showing 5 changed files with 831 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -82,7 +82,7 @@
     "gl-scatter3d": "^1.0.11",
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
-    "gl-surface3d": "^1.3.4",
+    "gl-surface3d": "^1.3.5",
     "glslify": "^6.1.1",
     "has-hover": "^1.0.1",
     "has-passive-events": "^1.0.0",

diff --git a/src/traces/surface/convert.js b/src/traces/surface/convert.js
@@ -342,6 +342,7 @@ proto.update = function(data) {
 
     surface.visible = data.visible;
     surface.enableDynamic = highlightEnable;
+    surface.enableHighlight = highlightEnable;
 
     surface.snapToData = true;
 

diff --git a/test/image/baselines/gl3d_contour-lines2.png b/test/image/baselines/gl3d_contour-lines2.png