add selectedpoints to uirevision framework

plotly · Nov 9, 2018 · 6a9d0d7 · 6a9d0d7
1 parent 03baca7
commit 6a9d0d7
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -2387,6 +2387,7 @@ var layoutUIControlPatterns = [
 // same for trace attributes: if `attr` is given it's in layout,
 // or with no `attr` we use `trace.uirevision`
 var traceUIControlPatterns = [
+    {pattern: /^selectedpoints$/, attr: 'selectionrevision'},
     // "visible" includes trace.transforms[i].styles[j].value.visible
     {pattern: /(^|value\.)visible$/, attr: 'legend.uirevision'},
     {pattern: /^dimensions\[\d+\]\.constraintrange/},

diff --git a/src/plots/cartesian/select.js b/src/plots/cartesian/select.js
@@ -666,6 +666,15 @@ function isOnlyOnePointSelected(searchTraces) {
 function updateSelectedState(gd, searchTraces, eventData) {
     var i, searchInfo, cd, trace;
 
+    // before anything else, update preGUI if necessary
+    for(i = 0; i < searchTraces.length; i++) {
+        var fullInputTrace = searchTraces[i].cd[0].trace._fullInput;
+        var tracePreGUI = gd._fullLayout._tracePreGUI[fullInputTrace.uid];
+        if(tracePreGUI.selectedpoints === undefined) {
+            tracePreGUI.selectedpoints = fullInputTrace._input.selectedpoints || null;
+        }
+    }
+
     if(eventData) {
         var pts = eventData.points || [];
 

diff --git a/src/plots/layout_attributes.js b/src/plots/layout_attributes.js
@@ -234,6 +234,15 @@ module.exports = {
             'Defaults to `layout.uirevision`.'
         ].join(' ')
     },
+    selectionrevision: {
+        valType: 'any',
+        role: 'info',
+        editType: 'none',
+        description: [
+            'Controls persistence of user-driven changes in selected points',
+            'from all traces.'
+        ].join(' ')
+    },
     template: {
         valType: 'any',
         role: 'info',

diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -1386,6 +1386,7 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut, formatObj) {
     coerce('datarevision');
     var uirevision = coerce('uirevision');
     coerce('editrevision', uirevision);
+    coerce('selectionrevision', uirevision);
 
     coerce('modebar.orientation');
     coerce('modebar.bgcolor', Color.addOpacity(layoutOut.paper_bgcolor, 0.5));