review fixes

plotly · Jul 5, 2017 · 8a308a8 · 8a308a8
1 parent ac2f7f4
commit 8a308a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/components/fx/attributes.js b/src/components/fx/attributes.js
@@ -38,6 +38,7 @@ module.exports = {
             valType: 'number',
             min: 0,
             dflt: 15,
+            arrayOk: true,
             role: 'style',
             description: 'Sets the length (in number of characters) of the hover labels for this trace'
         }

diff --git a/src/components/fx/hover.js b/src/components/fx/hover.js
@@ -689,7 +689,9 @@ function createHoverText(hoverData, opts, gd) {
             // strip out our pseudo-html elements from d.name (if it exists at all)
             name = svgTextUtils.plainText(d.name || '');
 
-            if(name.length > commonLabelOpts.namelength && commonLabelOpts.namelength > 0) name = name.substr(0, commonLabelOpts.namelength - 3) + '...';
+            if(commonLabelOpts.namelength > 0 && name.length > commonLabelOpts.namelength) {
+                name = name.substr(0, commonLabelOpts.namelength - 3) + '...';
+            }
         }
 
         // used by other modules (initially just ternary) that