Skip to content

Commit

Permalink
Merge pull request #6367 from plotly/fix-no-clearSelect-mapbox
Browse files Browse the repository at this point in the history
Fix mapbox clearOutline calls
  • Loading branch information
archmoj committed Nov 12, 2022
2 parents 35fb5b9 + 895ace5 commit f1e5e08
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions draftlogs/6367_fix.md
@@ -0,0 +1 @@
- Fix mapbox clearOutline calls (regression introduced in 2.13.0) [[#6367](https://github.com/plotly/plotly.js/pull/6367)]
4 changes: 2 additions & 2 deletions src/plots/mapbox/mapbox.js
Expand Up @@ -593,7 +593,7 @@ proto.updateFx = function(fullLayout) {
map.off('click', self.onClickInPanHandler);
if(selectMode(dragMode) || drawMode(dragMode)) {
map.dragPan.disable();
map.on('zoomstart', self.clearSelect);
map.on('zoomstart', self.clearOutline);

self.dragOptions.prepFn = function(e, startX, startY) {
prepSelect(e, startX, startY, self.dragOptions, dragMode);
Expand All @@ -602,7 +602,7 @@ proto.updateFx = function(fullLayout) {
dragElement.init(self.dragOptions);
} else {
map.dragPan.enable();
map.off('zoomstart', self.clearSelect);
map.off('zoomstart', self.clearOutline);
self.div.onmousedown = null;
self.div.ontouchstart = null;
self.div.removeEventListener('touchstart', self.div._ontouchstart);
Expand Down

0 comments on commit f1e5e08

Please sign in to comment.