no integer weight

plotly · Apr 22, 2024 · f4d4f4c · f4d4f4c
1 parent b8877ff
commit f4d4f4c
Show file tree

Hide file tree

Showing 3 changed files with 970 additions and 1,622 deletions.
diff --git a/src/lib/coerce.js b/src/lib/coerce.js
@@ -114,13 +114,8 @@ exports.valObjectMeta = {
             'are coerced to the `dflt`.'
         ].join(' '),
         requiredOpts: [],
-        otherOpts: ['dflt', 'min', 'max', 'arrayOk', 'extras'],
+        otherOpts: ['dflt', 'min', 'max', 'arrayOk'],
         coerceFunction: function(v, propOut, dflt, opts) {
-            if((opts.extras || []).indexOf(v) !== -1) {
-                propOut.set(v);
-                return;
-            }
-
             if(v % 1 || !isNumeric(v) ||
                     (opts.min !== undefined && v < opts.min) ||
                     (opts.max !== undefined && v > opts.max)) {

diff --git a/src/plots/font_attributes.js b/src/plots/font_attributes.js
@@ -51,10 +51,8 @@ module.exports = function(opts) {
 
         weight: {
             editType: editType,
-            valType: 'integer',
-            min: 1,
-            max: 1000,
-            extras: ['normal', 'bold'],
+            valType: 'enumerated',
+            values: ['normal', 'bold'],
             dflt: 'normal',
             description: [
                 'Sets the weight (or boldness) of the font.'