Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: Interpret fill and text color attribute arrays as periodic #2130

Open
jackparmer opened this issue Oct 27, 2017 · 8 comments
Open

table: Interpret fill and text color attribute arrays as periodic #2130

jackparmer opened this issue Oct 27, 2017 · 8 comments
Labels
feature something new P3 not needed for current cycle

Comments

@jackparmer
Copy link
Contributor

Alternating row colors doesn't translate very naturally to the workspace. It would be nice to have these shortcuts that override the other fill color attributes. It would also simplify table development in R and Python, as you wouldn't have to make an array of alternating colors every time.

image

@alexcjohnson
Copy link
Collaborator

Can we just allow these style attributes (fill and text colors) to be interpreted as periodic? So if you want even-odd you give length-2 arrays, but then if you want some other period you can do that too. Granted it would be awkward in the workspace if we want these to sometimes not be treated as data arrays but instead get set in the style panel, but I'm sure we can sort that out. Seem nicer than adding a bunch of new special-purpose attributes that restrict you to pure even-odd.

@jackparmer
Copy link
Contributor Author

jackparmer commented Oct 30, 2017 via email

@jackparmer jackparmer changed the title evenrowcolor and oddrowcolor shortcuts for table table: Interpret fill and text color attribute arrays as periodic Oct 30, 2017
@jackparmer
Copy link
Contributor Author

jackparmer commented Oct 30, 2017

Title changed from:
"evenrowcolor and oddrowcolor shortcuts for table"
To:
"table: Interpret fill and text color attribute arrays as periodic"

@alexcjohnson
Copy link
Collaborator

cc @monfera - should be an easy one, perhaps combined with #2133 when you get a chance.

@monfera
Copy link
Contributor

monfera commented Nov 1, 2017

Periodic interpretation would be quite straightforward, will do!

@monfera monfera self-assigned this Nov 1, 2017
@etpinard
Copy link
Contributor

Looks like something might be off in the current implementation:

https://community.plot.ly/t/possible-bug-with-table-cell-font-colors/6867/4

@marcstern14
Copy link

Has this been worked on at all? I'm getting a similar issue with font color using python.

@alexcjohnson
Copy link
Collaborator

@marcstern14 it has not - but we'd gladly accept a PR to add this. Should be pretty simple, just a matter of finding a few key places to add % whateverArray.length.

@gvwilson gvwilson self-assigned this Jun 10, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added the P3 not needed for current cycle label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P3 not needed for current cycle
Projects
None yet
Development

No branches or pull requests

6 participants