Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovers on cumulative histograms #2738

Closed
nicolaskruchten opened this issue Jun 15, 2018 · 2 comments
Closed

Hovers on cumulative histograms #2738

nicolaskruchten opened this issue Jun 15, 2018 · 2 comments
Labels
bug something broken

Comments

@nicolaskruchten
Copy link
Contributor

In this pen: https://codepen.io/nicolaskruchten/pen/RJLMVb?editors=0010# I see that the hovers label the first bin as "1" with a value of 2 and the second as "3" with a value of 3. It seems to me that the hover labels should indicate the upper edge of the bin, not its center: there are 2 values below 2, not below 1.

@etpinard etpinard added the bug something broken label Jun 29, 2018
@etpinard
Copy link
Contributor

I can't remember what @alexcjohnson had in mind for cumulative histogram hover back in #2113, but yeah this seems off.

Thanks @nicolaskruchten for the report.

@etpinard
Copy link
Contributor

Just found #2115 - which describes some potential cumulative histogram hover content.

Merging into #2115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants