Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbox subplots are broken in minified bundles #2787

Closed
etpinard opened this issue Jul 6, 2018 · 6 comments · Fixed by #2792
Closed

Mapbox subplots are broken in minified bundles #2787

etpinard opened this issue Jul 6, 2018 · 6 comments · Fixed by #2792

Comments

@etpinard
Copy link
Contributor

etpinard commented Jul 6, 2018

Starting in 1.39.0,

This one will be fun to debug 😑

@etpinard
Copy link
Contributor Author

etpinard commented Jul 6, 2018

Found mapbox/mapbox-gl-js#6648

@etpinard
Copy link
Contributor Author

etpinard commented Jul 6, 2018

@etpinard
Copy link
Contributor Author

etpinard commented Jul 6, 2018

Looks like bumping minify-stream from 1.1.0 to 1.2.0 in #2656 did this.

@etpinard
Copy link
Contributor Author

etpinard commented Jul 6, 2018

⤴️ , bumping minify-stream isn't the whole story. minify-stream@1.1.0 breaks for mapbox-gl@0.45.0+ (but worked fine with 0.44.x which we were using before 1.39.0) 😡

@etpinard
Copy link
Contributor Author

etpinard commented Jul 9, 2018

#2789 fixes this by disabling the compress step during minification. This fix is part of 1.39.1

This solution is far from perfect, so I'll leave this issue open until/if we figure a better solution.

@etpinard
Copy link
Contributor Author

etpinard commented Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant