Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade plotly.js to 1.39.1 #228

Merged
merged 4 commits into from Jul 9, 2018

Conversation

Projects
None yet
5 participants
@chriddyp
Copy link
Member

commented Jul 5, 2018

@plotly/dash please review

chriddyp added some commits Jul 5, 2018

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

💃 Looks good!

@cldougl

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

💃

@leejt489

This comment has been minimized.

Copy link

commented Jul 7, 2018

@chriddyp I was trying to pull in plotly 1.39.0 to see if it solved issue plotly/dash#223. I just locally changed __init__.py

'external_url': 'https://cdn.plot.ly/plotly-1.38.0.min.js',
to use version 1.39.0 for the external_url, which looked like the only thing you changed apart from downloading the new JS file and updating the relative_package_path and the version number. Everything deployed fine, but I started getting a new JavaScript error when the map is rendering:

Uncaught ReferenceError: t is not defined
(anonymous) @ blob:http://127.0.0.1:8050/d7192aea-f3a0-4f37-baf9-b238ca89d2b4:1
(anonymous) @ blob:http://127.0.0.1:8050/d7192aea-f3a0-4f37-baf9-b238ca89d2b4:1

I was able to produce this error on your example https://github.com/plotly/dash-recipes/blob/master/dash-plotly-132-histogram-map.py. I only commented out line 10 so as to use the external script.

Maybe this is just a local error for me as I was trying to get ahead of your release, but from what I can tell it seems likely this is a real issue. Maybe you want to take a look and ensure you don't get this error before pushing this new version?

@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2018

Thanks for reporting @leejt489 ! I'll take a look before releasing

@leejt489

This comment has been minimized.

Copy link

commented Jul 9, 2018

@chriddyp I'd hazard the guess that it's related to plotly/plotly.js#2787

@leejt489

This comment has been minimized.

Copy link

commented Jul 9, 2018

Yep, definitely related to that issue. For the record, referencing plotly 1.39.0 (full version, not minified) produced no errors and did indeed fix plotly/dash#223 ... just in time for my demo tomorrow :)

@etpinard

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

Bumping to plotly.js@1.39.1 will fix #228 (comment)

@chriddyp chriddyp changed the title upgrade plotly.js to 1.39.0 upgrade plotly.js to 1.39.1 Jul 9, 2018

@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

Bumped up to 1.39.1

@chriddyp chriddyp merged commit e7fcda4 into master Jul 9, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review automatically approved, no visual changes found.
Details

@chriddyp chriddyp deleted the plotlyjs-1.39.0 branch Jul 9, 2018

@chriddyp chriddyp referenced this pull request Aug 22, 2018

Closed

update plotly.js #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.