Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

upgrade plotly.js to 1.39.1 #228

Merged
merged 4 commits into from
Jul 9, 2018
Merged

upgrade plotly.js to 1.39.1 #228

merged 4 commits into from
Jul 9, 2018

Conversation

chriddyp
Copy link
Member

@chriddyp chriddyp commented Jul 5, 2018

@plotly/dash please review

@valentijnnieman
Copy link
Contributor

💃 Looks good!

@cldougl
Copy link
Member

cldougl commented Jul 6, 2018

💃

@leejt489
Copy link

leejt489 commented Jul 7, 2018

@chriddyp I was trying to pull in plotly 1.39.0 to see if it solved issue plotly/dash#223. I just locally changed __init__.py

'external_url': 'https://cdn.plot.ly/plotly-1.38.0.min.js',
to use version 1.39.0 for the external_url, which looked like the only thing you changed apart from downloading the new JS file and updating the relative_package_path and the version number. Everything deployed fine, but I started getting a new JavaScript error when the map is rendering:

Uncaught ReferenceError: t is not defined
(anonymous) @ blob:http://127.0.0.1:8050/d7192aea-f3a0-4f37-baf9-b238ca89d2b4:1
(anonymous) @ blob:http://127.0.0.1:8050/d7192aea-f3a0-4f37-baf9-b238ca89d2b4:1

I was able to produce this error on your example https://github.com/plotly/dash-recipes/blob/master/dash-plotly-132-histogram-map.py. I only commented out line 10 so as to use the external script.

Maybe this is just a local error for me as I was trying to get ahead of your release, but from what I can tell it seems likely this is a real issue. Maybe you want to take a look and ensure you don't get this error before pushing this new version?

@chriddyp
Copy link
Member Author

chriddyp commented Jul 8, 2018

Thanks for reporting @leejt489 ! I'll take a look before releasing

@leejt489
Copy link

leejt489 commented Jul 9, 2018

@chriddyp I'd hazard the guess that it's related to plotly/plotly.js#2787

@leejt489
Copy link

leejt489 commented Jul 9, 2018

Yep, definitely related to that issue. For the record, referencing plotly 1.39.0 (full version, not minified) produced no errors and did indeed fix plotly/dash#223 ... just in time for my demo tomorrow :)

@etpinard
Copy link

etpinard commented Jul 9, 2018

Bumping to plotly.js@1.39.1 will fix #228 (comment)

@chriddyp chriddyp changed the title upgrade plotly.js to 1.39.0 upgrade plotly.js to 1.39.1 Jul 9, 2018
@chriddyp
Copy link
Member Author

chriddyp commented Jul 9, 2018

Bumped up to 1.39.1

@chriddyp chriddyp merged commit e7fcda4 into master Jul 9, 2018
@chriddyp chriddyp deleted the plotlyjs-1.39.0 branch July 9, 2018 18:30
@chriddyp chriddyp mentioned this pull request Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants