Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D graph axis rendering in FF64 + mac #3387

Closed
ShaneHudson opened this issue Jan 3, 2019 · 16 comments
Closed

3D graph axis rendering in FF64 + mac #3387

ShaneHudson opened this issue Jan 3, 2019 · 16 comments
Assignees
Labels
bug something broken

Comments

@ShaneHudson
Copy link

ShaneHudson commented Jan 3, 2019

I've noticed graphs that look perfectly fine in Chrome look "dodgy" in Firefox. I'm not sure if it is to do with antialiasing or what but the labels and axis look many times better in Chrome.

Take the documentation's 3D surface graph for example: https://codepen.io/plotly/pen/MaxrwW

Firefox:
screenshot 2019-01-03 10 31 06

Chrome:
screenshot 2019-01-03 10 31 31

Is there anything that can be done to improve this? Firefox definitely gets a less polished result. While it looks "ok" in the screenshots, if you actually interact with the graphs Firefox is even worse.

@etpinard
Copy link
Contributor

etpinard commented Jan 3, 2019

Thanks for the report.

Can you tell us which Firefox version you're using and which OS you're on. Some info about your hardware might be nice also.

Thank again.

@ShaneHudson
Copy link
Author

ShaneHudson commented Jan 3, 2019

Firefox 64.0 (64-bit)
MacBook Pro (15-inch, 2016) Retina
High Sierra 10.13.6
2.7 GHz Intel Core i7
16 GB 2133 MHz LPDDR3
Radeon Pro 455 2048 MB
Intel HD Graphics 530 1536 MB

Hope that helps :)

@ShaneHudson
Copy link
Author

On my project I've got the axis and text as white on grey and it flickers badly on interaction in Firefox (as it does in the demo but more obvious if you change colours).

@ShaneHudson
Copy link
Author

Chrome Version 71.0.3578.98 (Official Build) (64-bit) works fine

@etpinard
Copy link
Contributor

etpinard commented Jan 3, 2019

Thanks @ShaneHudson

Looks like we have another FF64 + mac bug (cc #3385)

@etpinard etpinard changed the title 3D graph axis rendering in Firefox 3D graph axis rendering in FF64 + mac Jan 7, 2019
@etpinard etpinard added the bug something broken label Jan 7, 2019
@etpinard
Copy link
Contributor

@archmoj any hints on why this is happening?

@archmoj
Copy link
Contributor

archmoj commented Feb 20, 2019

@ShaneHudson thanks for the report.
Could you please download the graphs as png using the Plotly.js modebar (at initial camera position) on Chrome and Firefox, and them upload them here?

@ShaneHudson
Copy link
Author

Chrome: chrome_plotly
Firefox: firefox_plotly

The issue doesn't seem to exist when downloading as png.

@ShaneHudson
Copy link
Author

It's slightly worse in Firefox but not as bad as viewing in browser (without even interacting).

@ShaneHudson
Copy link
Author

screenshot 2019-02-20 16 52 16
Here's another example of Firefox in browser

@archmoj
Copy link
Contributor

archmoj commented Feb 21, 2019

This issue is basically related to a limitation that some browsers (not Chrome) don't apply antialias: true webgl flag.
In the first codepen the antialias is set to false to illustrate similar undesirable performance may happen in Chrome when it is disabled by default.
This second codepen which imports Plotly at 1.44.4 could also be handy for a comparison (again using Chrome) .
@etpinard @alexcjohnson To improve this behaviour for FF & iOS users one idea could be to increase line widths e.g. in gl-axes3d vertex shader program. What do you think of that?

@etpinard
Copy link
Contributor

To improve this behaviour for FF & iOS users one idea could be to increase line widths e.g. in gl-axes3d vertex shader program. What do you think of that?

Yep, let's try that out!

@etpinard
Copy link
Contributor

... and generate all the gl3d baselines up on a branch.

@archmoj
Copy link
Contributor

archmoj commented Feb 22, 2019

@ShaneHudson now on iOS and FireFox would you mind checking this third codepen, and also comparing this one which is based on your example; and possibly confirm the improvements?

@ShaneHudson
Copy link
Author

screenshot 2019-02-22 09 40 10

screenshot 2019-02-22 09 41 30

That seems to have done the job! Possibly not identical to Chrome but big improvement on what Firefox is currently.

iOS looks fine too 👍

@archmoj
Copy link
Contributor

archmoj commented Feb 24, 2019

@ShaneHudson Thanks for the feedback. Would you mind testing this revised example as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants