Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotly-locale-nl-latest.js is not latest translations for nl locale #6399

Closed
eirvandelden opened this issue Dec 15, 2022 · 2 comments
Closed

Comments

@eirvandelden
Copy link
Contributor

eirvandelden commented Dec 15, 2022

What I did:

  • include <script src="https://cdn.plot.ly/plotly-locale-nl-latest.js"></script> to get latest nl locale

What I expected:

  • The translations like in https://github.com/plotly/plotly.js/blob/master/lib/locales/nl.js with translations in the dictionary part and updates to dayMonth

What I got:

  • Only the days and months are translated. Actual content hosted now:
var locale={moduleType:"locale",name:"nl",dictionary:{},format:{days:["zondag","maandag","dinsdag","woensdag","donderdag","vrijdag","zaterdag"],shortDays:["zon","maa","din","woe","don","vri","zat"],months:["januari","februari","maart","april","mei","juni","juli","augustus","september","oktober","november","december"],shortMonths:["jan","feb","maa","apr","mei","jun","jul","aug","sep","okt","nov","dec"],date:"%d-%m-%Y"}};"undefined"==typeof Plotly?(window.PlotlyLocales=window.PlotlyLocales||[],window.PlotlyLocales.push(locale)):Plotly.register(locale);

I think what is hosted on https://cdn.plot.ly/plotly-locale-nl-latest.js is not the latest, but a version before my changes were merged and released in 2.14.0: #6261

@eirvandelden eirvandelden changed the title plotly-locale-nl-latest.js is not plotly-locale-nl-latest.js is not latest translations for nl locale Dec 15, 2022
@alexcjohnson
Copy link
Collaborator

We stopped updating latest when we released v2.0, to avoid accidental breaking changes

@eirvandelden
Copy link
Contributor Author

Ooooh, I hadn't realized that was for both the library and translations 🙈

Thanks for commenting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants