Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nl translation #6261

Merged
merged 10 commits into from Aug 10, 2022
Merged

Conversation

eirvandelden
Copy link
Contributor

@eirvandelden eirvandelden commented Jul 14, 2022

Thanks for your interest in plotly.js!

Translations:

  • People who can assist in verifying the dutch words: @rriksma-fouriq, @shendriks-fouriq, @ariejan
  • Keys I've committed are buttons we don't use in our own application and I'm not confident enough to translate without any context. Especially hover would translate to a very verbose way

Features, Bug fixes, and others:

Before opening a pull request, developer should:

  • 1. make sure they are not on the master branch of their fork as using master for a pull request would make it difficult to fetch upstream changes.

  • 2. fetch latest changes from upstream/master into your fork i.e. origin/master then pull origin/master from you local master.

  • 3. then git rebase master their local dev branch off the latest master which should be sync with upstream/master at this time.

  • 4. make sure to not git add the dist/ folder (the dist/ is updated only on version bumps).

  • 5. make sure to commit changes to the package-lock.json file (if any new dependency required).

  • 6. provide a title and write an overview of what the PR attempts to do with a link to the issue they are trying to address.

  • 7. select the Allow edits from maintainers option (see this article for more details).

After opening a pull request, developer:

  • - should create a new small markdown log file using the PR number e.g. 1010_fix.md or 1010_add.md inside draftlogs folder as described in this README, commit it and push.

  • should not force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetch upstream/master and "merge" with master instead of "rebase".

@eirvandelden
Copy link
Contributor Author

I've also added the draft log file, though I'm not sure if it was required for a translation change. If anything else is needed, let me know!

lib/locales/nl.js Outdated Show resolved Hide resolved
lib/locales/nl.js Outdated Show resolved Hide resolved
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
lib/locales/nl.js Outdated Show resolved Hide resolved
lib/locales/nl.js Outdated Show resolved Hide resolved
lib/locales/nl.js Outdated Show resolved Hide resolved
lib/locales/nl.js Outdated Show resolved Hide resolved
eirvandelden and others added 4 commits July 18, 2022 16:28
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: rriksma-fouriq <51152705+rriksma-fouriq@users.noreply.github.com>
Co-authored-by: rriksma-fouriq <51152705+rriksma-fouriq@users.noreply.github.com>
@archmoj
Copy link
Contributor

archmoj commented Aug 9, 2022

Please add spaces here so that the test pass & and we could possibly include it in the next plotly.js minor soon.
Thank you!

$ eslint .
/home/circleci/plotly.js/lib/locales/nl.js
   7:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
   8:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
   9:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  10:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  11:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  12:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  13:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  14:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  15:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  16:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  17:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  18:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  19:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  20:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  21:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  22:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  23:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  24:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  25:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  26:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  27:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  28:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  29:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  30:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  31:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  32:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  33:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  34:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  35:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  36:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  37:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  38:7  error  Expected indentation of 8 spaces but found 6  indent-legacy
  39:7  error  Expected indentation of 8 spaces but found 6  indent-legacy

@archmoj
Copy link
Contributor

archmoj commented Aug 10, 2022

💃
I'll fix the linting right after.
The updates would be in v2.14.0 shortly.
Thanks very much.

@archmoj archmoj merged commit 1c4b332 into plotly:master Aug 10, 2022
@eirvandelden
Copy link
Contributor Author

Please add spaces here so that the test pass & and we could possibly include it in the next plotly.js minor soon. Thank you!

Sorry that I didn't apply thee added spaces, I was on holiday🙈. Thanks for changing, glad to have helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants