Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menus open items #810

Closed
etpinard opened this issue Aug 3, 2016 · 6 comments
Closed

Update menus open items #810

etpinard opened this issue Aug 3, 2016 · 6 comments

Comments

@etpinard
Copy link
Contributor

etpinard commented Aug 3, 2016

Layout menu feature PR: #770

Open items:

  • Should we do some validation for 'args' depending on method or just let Plotly[method] error out?
  • Should add more global settings:
    • width
    • height (instead of being inferred by the label dimensions)
    • title (above header)
    • header borderwidth
    • active / hover bgcolor
    • gap between buttons
    • gap between header & buttons
  • We should probably make dropdown items scrollable
  • Should the dropdown arrow direction depend on direction see Add button type to updatemenus #974 (comment)
@jackparmer
Copy link
Contributor

We should probably make dropdown items scrollable

Yep. Here's someone struggling with this out-in-the-wild. Also came up from a customer @charleyferrari chatted up today.

https://plot.ly/~Scochran/159/price-vs-date/

@rreusser
Copy link
Contributor

rreusser commented Aug 29, 2016

Closing #890 in favor of this. I'll only add that if menus scrolled, that would presumably also solve the hard limit of six items (a very hard limit—the menu disappears if you exceed six).

Edit: one more thing: I found the menu takes up too much vertical space where it should instead probably just overlap the plot when expanded. There may be a config option to work around this, but unless there's a reason I'm not seeing, it should perhaps be the default. See #890 for screenshot and example.

@rreusser
Copy link
Contributor

@etpinard — What do you think about changing the expanded menu to HTML? It will be a bit awkward to position relative to the top-level SVG container, but it would probably be significantly more accessible and require 80% less code. Plus, it's not clear to me why you'd want the expanded menu to be rendered to SVG. Just a thought as I look through what it means to implement complex controls in SVG.

@Kully
Copy link
Contributor

Kully commented Oct 25, 2016

Another user who is having trouble accessing menu items past the 10th one or so: https://plot.ly/~wholleran/829/completion-percentage-vs-period/?share_key=J0gquGi2vrEhTurmsYsP3s

@jackparmer
Copy link
Contributor

Hey @n-riesco - Can you take this before you go onto animations for bars? (At least making it scroll-able). Thanks!

@etpinard
Copy link
Contributor Author

etpinard commented Feb 8, 2017

Closing as the main item on the list ⏫ was completed in #1214 and #1345 repeats the title option request. The other items on the list are of much lesser priority.

@etpinard etpinard closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants