Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange behavior with missing values in scattergeo #963

Closed
cpsievert opened this issue Sep 22, 2016 · 2 comments · Fixed by #1004
Closed

Strange behavior with missing values in scattergeo #963

cpsievert opened this issue Sep 22, 2016 · 2 comments · Fixed by #1004
Assignees
@etpinard
Labels
type: bug
Milestone
v1.18.0

Comments

@cpsievert
Copy link

http://codepen.io/cpsievert/pen/ZpLbxJ

I discovered this problem when using scatter to make a map of canada:

screen shot 2016-09-21 at 7 28 16 pm

Supplying the same data to scattergeo gives me this:

screen shot 2016-09-21 at 7 29 26 pm

Thus, it seems like [0, 0] is being inserted before (or possibly after) null?
@cpsievert
Copy link
Author

Also, this seems to work fine with scattermapbox

@etpinard etpinard self-assigned this Sep 22, 2016
@etpinard etpinard mentioned this issue Sep 22, 2016
Closed
@etpinard etpinard added this to the v1.18.0 milestone Sep 22, 2016
@etpinard
Copy link
Contributor

I changed my mind. Instead of simply making sure that non-numeric values are skipped in scattergeo traces (as in #964), I'll refactor combine some of the scattermapbox logic into scattergeo should make it easy to add connectgaps to and fill: 'toself' support to scattergeo traces - and maybe also hover text for scattergeo lines in 1.18.0.

@etpinard etpinard mentioned this issue Sep 27, 2016
Closed
etpinard added a commit that referenced this issue Oct 4, 2016
@etpinard
scattergeo: add proper calc step
52c1b89 
- which skips and cast lon/lat values
- fixes #963
- note that 'locations[i]' -> feature must still be
  done at the plot (after the topojson is loaded)
@etpinard etpinard mentioned this issue Oct 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
type: bug
Projects
None yet
Milestone
v1.18.0
2 participants
@cpsievert @etpinard