Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased WebGL 2D projection precision - updated dependencies and mock #1114

Merged
merged 1 commit into from
Nov 8, 2016

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Nov 5, 2016

The preceding changes (#1033) vastly improved the precision of projections but further testing found realistic scenarios where the resolution was subpar. This PR is just an explicit dependency version bump as plotly.js itself didn't have to change. The nature of the changes in the WebGL dependencies was the switch of scaling and translation, an example of which is: https://github.com/gl-vis/gl-scatter2d-fancy/pull/3/files

The image mock also changed, as apparently, the WebGL images generated in the test environment aren't quite faithful to regular operations, and a dependency precision change altered one of the traces.

@monfera
Copy link
Contributor Author

monfera commented Nov 5, 2016

@etpinard Some tests on codepen, with powers of 2 steps, starting with 1ms and ending in the iron and bronze age, respectively:

@etpinard
Copy link
Contributor

etpinard commented Nov 7, 2016

@monfera the change seems sound to me.

Can you explain why your patches generated an image diff:

image

Looks like the rightmost marker pt isn't showing anymore. Is that expected?

@monfera
Copy link
Contributor Author

monfera commented Nov 7, 2016

@etpinard Yes I initially suspected that it was a clipping issue, in that maybe the projection didn't work with the point size, i.e. it thought that the point is invisible. But it's not the case. It's a similar artifact to the line artifact - if you run it interactively e.g. by putting the mock into a jasmine test, it's good.

@etpinard
Copy link
Contributor

etpinard commented Nov 7, 2016

Interesting.

if you run it interactively e.g. by putting the mock into a jasmine test, it's good.

So you're suspecting discrepancies in our nw.js image server? If so, we should try to find a way to test the increased precision in our jasmine suite.

@etpinard
Copy link
Contributor

etpinard commented Nov 7, 2016

💃

@monfera monfera force-pushed the test-increase-projection-precision branch from ea945f1 to a112bc8 Compare November 7, 2016 16:36
@monfera monfera changed the title [TMP] test increased projection precision Increased WebGL 2D projection precision - updated dependencies and mock Nov 7, 2016
@etpinard etpinard added this to the v1.20.0 milestone Nov 8, 2016
@etpinard
Copy link
Contributor

etpinard commented Nov 8, 2016

Thanks @monfera

@etpinard etpinard merged commit 5da21cb into plotly:master Nov 8, 2016
@etpinard etpinard mentioned this pull request Feb 15, 2017
15 tasks
@dy dy mentioned this pull request Aug 24, 2017
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants