Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] First cut at animating bar graphs #1143

Closed
wants to merge 1 commit into from
Closed

Conversation

rreusser
Copy link
Contributor

This PR adds object constancy for bar graphs. It seems like barmode: 'relative' has problems.

barmode: 'stack':

stack

barmode: 'group':

group

barmode: 'overlay':

overlay

barmode: 'relative':

relative

@JonDum
Copy link

JonDum commented Dec 29, 2016

I'm sad this never landed! I just spent an hour trying to figure out why Bar charts weren't animating cause it seemed like such a simple thing that it must be supported.

@grahamscott
Copy link

I'm really interested to know if this is likely to land as a feature soon?

@rreusser
Copy link
Contributor Author

rreusser commented Feb 9, 2017

@grahamscott I'm hoping will get a chance to loop back to it in the next week or so. Getting it started was pretty easy, but I don't yet know all the ins and outs of bar graphs and need maybe a day or two to lock down the remaining details. barmode: 'relative' is currently the one that was causing problems, though I suspect there are a decent number of details I still need to address.

@JonDum
Copy link

JonDum commented Feb 9, 2017

@rreusser I am 100% ok with some of the less commonly used bar modes not being supported at first if it means some form of support can be merged in the meantime.

@grahamscott
Copy link

@rreusser Thank you for getting back to me. I'm hoping we'll see this land then 👍

@rreusser rreusser closed this Jun 17, 2017
@etpinard etpinard mentioned this pull request May 29, 2019
@etpinard etpinard deleted the animate-bar-graphs branch July 26, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants