Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar marker color array legend style #1289

Merged
merged 6 commits into from Jan 17, 2017
Merged

Fix bar marker color array legend style #1289

merged 6 commits into from Jan 17, 2017

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jan 9, 2017

fixes #1212

... bringing legend support for bar maker color arrays on par with scatter.

]
],
"layout": {
"showlegend": true
Copy link
Contributor Author

@etpinard etpinard Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which looked like

image

before 5d0d930

@etpinard etpinard added this to the v1.22.0 milestone Jan 16, 2017
@@ -172,13 +172,14 @@ function styleBars(d) {
barpath.exit().remove();
barpath.each(function(d) {
var w = (d.mlw + 1 || markerLine.width + 1) - 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need d -> d0 too? care to include line width and color arrays into the same mock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👁️

Done in 8e718bf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for completeness:

and color arrays

ie marker.line.color

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 81d3db1

"red",
"green",
"blue",
"yellow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing of beauty :)

@alexcjohnson
Copy link
Contributor

💃

@etpinard etpinard merged commit cebdb15 into master Jan 17, 2017
@etpinard etpinard deleted the bar-legend-style branch January 17, 2017 21:42
@nitram9
Copy link

nitram9 commented Nov 16, 2020

@etpinard, Im afraid this is occurring again in 2020. Could you take a look please?

@alexcjohnson
Copy link
Contributor

@nitramwin can you open a new issue with a codepen showing the problem you've encountered?

@nitram9
Copy link

nitram9 commented Nov 16, 2020

@alexcjohnson This is my first time making a codepen - I hope this works. https://codepen.io/nitramwin/pen/mdEoxZo

@archmoj
Copy link
Contributor

archmoj commented Nov 16, 2020

@alexcjohnson This is my first time making a codepen - I hope this works. https://codepen.io/nitramwin/pen/mdEoxZo

Thanks @nitramwin. Tracked in #5285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend color turns black if specifying specific colors for each bar
4 participants