Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement in how gl2d refs to fullLayout are updated #1319

Merged
merged 3 commits into from
Jan 19, 2017
Merged

Improvement in how gl2d refs to fullLayout are updated #1319

merged 3 commits into from
Jan 19, 2017

Commits on Jan 17, 2017

  1. rm useless Fx.supplyDefaults call in doModeBar subroutine 

    - as the full Plots.supplyDefaults is called before the
  doModeBar subroutine.
    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    ee6d7d8 View commit details
    Browse the repository at this point in the history

  2. replace scene2d.updateFx with scene2d.updateRefs 

    - scene2d.updateRefs is now called on scene2d.plot
  and during Plots.supplyDefaults, ensuring that
  scene2d.fullLayout is up-to-date with gd._fullLayout.
    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    ce1cc44 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2017

  1. attach scene2d relayoutCallback onto proto 

    - call after each mouse-change / wheel-change,
  as opposed to each time the scene2d ticks changed
  (which didn't cover all the cases)
- make sure gl2d pan test `mouseup` to trigger relayoutCallback
    @etpinard
    etpinard committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    c8b53dd View commit details
    Browse the repository at this point in the history