Extend input relayout & restyle objects before looping over key-vals #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that if key-vals need to be mapped (this happens for annotations relayout calls), the input object doesn't get mutated.
|
Good call 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/plotly/streambed/issues/9172
In a few cases, given:
the input
updateObjis mutated by the relayout logic while converting aliases for example here when relayout'ing annotations.This bug became very problematic for update menu buttons relayout annotations (example) where it caused the buttons to stop working after repeated clicks.
Note that, the restyle object - i.e. as in
Plotly.restyle(gd, restyleObject, traces)- are never mutated. In this PR, I chose to extend them anyway in case we do start mutating them down the road.