Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartesian dropline support #1461

Merged
merged 30 commits into from
Apr 18, 2017
Merged

Cartesian dropline support #1461

merged 30 commits into from
Apr 18, 2017

Commits on Mar 10, 2017

  1. Cartesian dropline support

    Draw droplines to the x and y axes on hover if the option is enabled and we're not on 'compare' hovermode.
    rpaskowitz committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    d9fab15 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2017

  1. Removed chart config for showDroplines

    Added axis layout option for showspikes
    Added background behind droplines
    Added axis indicator marker, including on free anchored axes
    Always draw dropline to chart limit, including for shared axes - not drawing all the way to free anchored axes
    rpaskowitz committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    5d39b53 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2017

  1. Add spikecolor, spikethickness, spikedash and spikemode

    Move 'dash' function to lib for re-use
    Use dynamic contrast color based on same logic as hovertext contrast text
    rpaskowitz committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    be47533 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17d815c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    162068e View commit details
    Browse the repository at this point in the history
  4. Move dashStyle to Drawing

    Make single attr calls
    Add crisp style
    Fix edge case when leaving and returning to closest hovermode
    rpaskowitz committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    762b54a View commit details
    Browse the repository at this point in the history
  5. Name back to showspikes

    Keep spike background color to the chart background, unless the series color is too close, then use contrast color
    rpaskowitz committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    d680bd4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2433d4c View commit details
    Browse the repository at this point in the history
  7. add spikeline icon

    etpinard committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    75da2fe View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7953488 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2017

  1. Configuration menu
    Copy the full SHA
    55b17b2 View commit details
    Browse the repository at this point in the history
  2. Refactor dropline to spikeline

    Fix modebar tests, and add some new ones
    Add spikeline tests
    Final adjustment to marker placement to account for y-axis on right side
    rpaskowitz committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b9f6ab1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7fe4363 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    34a1562 View commit details
    Browse the repository at this point in the history
  5. Move spike setup from axis to layout.

    Fix 'across' for right-side axes.
    rpaskowitz committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    8c7ac76 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Configuration menu
    Copy the full SHA
    6e243de View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2017

  1. Configuration menu
    Copy the full SHA
    c036bf7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2017

  1. Configuration menu
    Copy the full SHA
    08371c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69dc781 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37b77fe View commit details
    Browse the repository at this point in the history
  4. alter logic for where spikes start and end

    - toaxis always goes from the point to the axis, even for free axes
    - across spans all counteraxes with subplots for this axis, and
      extends to the free axis if it exists
    - fixed a bug with positioning after scrolling gd within a container
    - also short-circuited calculations we don't need
    alexcjohnson committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    710d2d6 View commit details
    Browse the repository at this point in the history
  5. lint

    alexcjohnson committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    e509fa7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. 🔪 spikemode: 'none'

    alexcjohnson committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    75121d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd11567 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a9aa58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    052417b View commit details
    Browse the repository at this point in the history
  5. 🔪 fit

    alexcjohnson committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    a3a0a4f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2017

  1. fix scattermapbox defaults for omitted options

    I had to make a mock marker.line object in _fullData to keep legends happy,
    but at least it doesn't respond to values in data.
    alexcjohnson committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    f7b467e View commit details
    Browse the repository at this point in the history
  2. lint

    alexcjohnson committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    7aa4359 View commit details
    Browse the repository at this point in the history
  3. 🔪 🔪

    alexcjohnson committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    5925049 View commit details
    Browse the repository at this point in the history