numeric sort for component edits #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
May 1, 2017
src/plot_api/manage_arrays.js
Outdated
| @@ -101,7 +101,7 @@ exports.applyContainerArrayChanges = function applyContainerArrayChanges(gd, np, | |||
| return true; | |||
| } | |||
|
|
|||
| var componentNums = Object.keys(edits).map(Number).sort(), | |||
| var componentNums = Object.keys(edits).map(Number).sort(function(a, b) { return a - b; }), | |||
There was a problem hiding this comment.
You might want to use Lib.sorterAsc to DRY it up 🌴
There was a problem hiding this comment.
ah thanks - should've guessed we'd have that already exposed somewhere!
etpinard
reviewed
May 1, 2017
| @@ -223,6 +223,33 @@ describe('annotations relayout', function() { | |||
| .then(done); | |||
| }); | |||
|
|
|||
| it('should sort correctly when index>10', function(done) { | |||
|
💃 after that little bit of 🌴 |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the first time I've been bitten by the default sort being alphabetical even if the items are numbers... This made a bug where if you tried to add annotations 9 and 10 in a single
relayout, it would try to add 10 first but it couldn't do that because 9 didn't exist yet (or if it did, 10 would get inserted in the array in the wrong places) and similar problems on deletion.@etpinard OK?