Putting CSS transform test outside condition

[monfera]

The test should also work in case val is not a string.

[monfera]

@alexcjohnson I made a test CI run with this, i.e. making it throw the error, and indeed CI balks, aptly, at the mock that triggers the offending code. The resulting error is quite opaque though. Am I doing something weird or would there be a way for emitting the error message in the CI log the way it's thrown in strict-d3 i.e. a descriptive error message?

/home/ubuntu/plotly.js/tasks/util/common.js:6
    errorCb = errorCb ? errorCb : function(err) { if(err) throw err; };
                                                          ^

Error: Command failed: sudo lxc-attach -n $(docker inspect --format '{{.Id}}' imagetest) -- bash -c "export CIRCLECI=1 && cd /var/www/streambed/image_server/plotly.js && node test/image/compare_pixels_test.js "
buffer.js:655
          throw new TypeError('Unknown encoding: ' + encoding);
          ^

TypeError: Unknown encoding: sankey_energy_dark:
    at Buffer.write (buffer.js:655:17)
    at fromString (buffer.js:173:26)
    at new Buffer (buffer.js:61:12)
    at createWriteReq (net.js:741:38)
    at Socket._writeGeneric (net.js:693:11)
    at Socket._write (net.js:716:8)
    at doWrite (_stream_writable.js:300:12)
    at writeOrBuffer (_stream_writable.js:286:5)
    at Socket.Writable.write (_stream_writable.js:214:11)
    at Socket.write (net.js:642:40)

    at ChildProcess.exithandler (child_process.js:202:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:850:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)

npm ERR! Linux 3.13.0-119-generic
npm ERR! argv "/opt/circleci/nodejs/v6.1.0/bin/node" "/opt/circleci/nodejs/v6.1.0/bin/npm" "run" "test-image"
npm ERR! node v6.1.0
npm ERR! npm  v3.8.6
npm ERR! code ELIFECYCLE
npm ERR! plotly.js@1.27.1 test-image: `node tasks/test_image.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the plotly.js@1.27.1 test-image script 'node tasks/test_image.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the plotly.js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node tasks/test_image.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs plotly.js
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls plotly.js
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/plotly.js/npm-debug.log

[etpinard]

Am I doing something weird or would there be a way for emitting the error message in the CI log the way it's thrown in strict-d3 i.e. a descriptive error message?

You're not doing anything wrong. That's just how the (current) image server handles errors. No need in trying to improve it, that thing will be replaced soon.