fix bug with unhover in gl2d #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you mouseout of the gl2d plot while hovering on a point, this ensures that unhover will be triggered. prior to this the test "scattergl after visibility restyle" consistently failed for me locally
|
Looks good! Thanks for the fix! 💃 when you feel like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on axis constraints by restricting domain, I found that a bunch of tests were failing locally for me, consistently, on master as well as my branch. Most just needed increased tolerances so I'll just include them in the constraints PR. But this one, "scattergl after visibility restyle", pointed to a real bug in gl2d: if you mouseout of the gl2d plot while hovering on a point, it will not unhover.
@etpinard I guess in principle this should be an independent PR into master (in which case it would also need another commit from my branch that cleaned up the test suite so I could see where the failure was) but I need it in my
constrain-domainbranch to get tests to pass and somehow noone else encountered this error?It would also be nice eventually if the
mouse-changepackage would handle this itself somehow, rather than just calling itsclearStatethat's indistinguishable from a real hover event. But for now it seemed like we should handle this within the gl2d scene.