Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array support for trace hoverinfo #1761

Merged
merged 10 commits into from
Jun 6, 2017
Merged

Array support for trace hoverinfo #1761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aab3366
implement arrayOk hoverinfo in Fx.hover
etpinard Jun 5, 2017
2acf548
rm obsolete gd.data.length -> pointData.name logic in Fx.hover
etpinard Jun 5, 2017
b649b11
fix scattercarpet hoverinfo flags declaration
etpinard Jun 6, 2017
7ed8681
add Lib.coerceHoverinfo shortcut
etpinard Jun 6, 2017
371d31e
use Fx.castHoverOption to setup pie loneHover args
etpinard Jun 6, 2017
e8a9ddd
add arrayOk support for hoverinfo for gl3d, gl2d and pie traces
etpinard Jun 6, 2017
3c693a0
make findArrayAttributes track arrayOk attrs in base trace attrs
etpinard Jun 6, 2017
d7999e2
'fill' fx calcdata items instead of 'merging' them
etpinard Jun 6, 2017
3c3fda4
:dolls: for Lib.mergeArray vs Lib.fillArray
etpinard Jun 6, 2017
d1f03c0
fix typo in :dolls:
etpinard Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plot_api/plot_schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ exports.findArrayAttributes = function(trace) {
return stack.join('.');
}

exports.crawl(baseAttributes, callback);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha nice, that's a lot simpler than I was afraid it might be!

exports.crawl(trace._module.attributes, callback);

if(trace.transforms) {
Expand Down
19 changes: 19 additions & 0 deletions test/jasmine/tests/transform_filter_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,25 @@ describe('filter transforms calc:', function() {
expect(out[0].marker.color).toEqual([0.3, 0.3, 0.4]);
});

it('filters should handle array on base trace attributes', function() {
var out = _transform([Lib.extendDeep({}, base, {
hoverinfo: ['x', 'y', 'text', 'name', 'none', 'skip', 'all'],
hoverlabel: {
bgcolor: ['red', 'green', 'blue', 'black', 'yellow', 'cyan', 'pink'],
},
transforms: [{
type: 'filter',
operation: '>',
value: 0
}]
})]);

expect(out[0].x).toEqual([1, 2, 3]);
expect(out[0].y).toEqual([2, 3, 1]);
expect(out[0].hoverinfo).toEqual(['none', 'skip', 'all']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this patch, we had

out[0].hoverinfo 
// => ['x', 'y', 'text', 'name', 'none', 'skip', 'all']

expect(out[0].hoverlabel.bgcolor).toEqual(['yellow', 'cyan', 'pink']);
});

it('filters should skip if *enabled* is false', function() {
var out = _transform([Lib.extendDeep({}, base, {
transforms: [{
Expand Down