Update dependencies + bye bye 'old d3 quirk' #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
changed the title
| exports.svgAttrs = { | ||
| xmlns: exports.svg, | ||
| 'xmlns:xlink': exports.xlink | ||
| }; |
|
Can't see anything wrong with this. Nice to clean up some of those long strings too. 💃 |
|
👍 looks good |
etpinard
added a commit
that referenced
this pull request
Jan 21, 2016
Update dependencies + bye bye 'old d3 quirk'
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson @mdtusz @cldougl
I updated all out dependencies to their latest versions (using
npm outdated).Everything went smoothly, except for
d3where in its v3.5.7 fixed the old d3 quirk requiring thexmlnsnamespaces to be input twice in.attr().Issue: d3/d3#1935
Fix: d3/d3@a6f66e9
I took the opportunity to add a file under
src/constantsexporting all the xmlns urls.