scatter & bar hover fixes for #780 #2218
Conversation
scatter was too permissive and too flat in its distance function in compare mode bar was too restrictive, in compare mode it now allows hover while in the gap between bars/groups
| var rad = Math.max(3, di.mrc || 0); | ||
| return Math.max(Math.abs(xa.c2p(di.x) - xpx) - rad, 1 - 3 / rad); |
There was a problem hiding this comment.
I think I copied this piece of logic elsewhere e.g. in scattergeo/hover.js. Should we update it there too?
There was a problem hiding this comment.
scattergeo should be fine, as it only uses the closest form (ie real quadrature distance, not just x or just y). I suppose the minRad change is still relevant there, to better handle line-only traces, but that's it.
|
|
||
| afterEach(destroyGraphDiv); | ||
|
|
||
| it('shows hover info for both traces', function(done) { |
| @@ -1274,7 +1311,7 @@ describe('hover updates', function() { | |||
|
|
|||
| afterEach(destroyGraphDiv); | |||
|
|
|||
| function assertLabelsCorrect(mousePos, labelPos, labelText) { | |||
| function assertLabelsCorrect(mousePos, labelPos, labelText, msg) { | |||
There was a problem hiding this comment.
Great. So none of the current tests needed to be updated, is that correct?
| }) | ||
| .then(unhover) | ||
| .then(function() { | ||
| expect(hoverCnt).toEqual(1); | ||
| expect(unHoverCnt).toEqual(1); | ||
|
|
||
| return assertLabelsCorrect([400, 200], [435, 198], '3'); | ||
| return assertLabelsCorrect([420, 100], [435, 198], '3', 'events 1'); |
There was a problem hiding this comment.
Ha. Found one. Why did this change?
There was a problem hiding this comment.
x=400 is a little too far away using the new compare logic. I don't know exactly where the center of the marker is (that's why I've moved to more explicitly-sized-and-ranged plots for tests like this, so we can easily reason about the pixel positions of different points), probably the test would have worked just increasing to 405 or something but I just moved the mouse to a point I knew would be in range.
|
Looks great. Thanks for the clarifications. 💃 |
Fixes #780 - @etpinard another quick bugfix for you to look at.
Scatter hover was too permissive and too flat in its distance function in compare mode - so it would call the wrong point "closest" sometimes. That was the main culprit in #780, we were matching a scatter point with one x value to a bar with a different x and concluding that they really shouldn't "compare" with each other, so tossing out the bar.
Bar hover was also too restrictive, it would not allow you to be hovered on a bar if the mouse was over the gap between bars. Now in compare mode it allows that, which makes for a more pleasant (and useful) effect as you mouse over, particularly when the bars are very narrow: the hover labels don't flash on/off anymore, there's always one showing.
For both trace types I left "closest" hover behavior as it was. In particular this means the "flashing" effect for bars is still there in this mode. Perhaps there would be a way to fix it at least for very thin bars, by rounding outward or something in our acceptance criteria, but at least this doesn't seem to lead to any explicit bugs.