Relink less stuff #2375
Relink less stuff #2375
Conversation
| @@ -12,6 +12,7 @@ module.exports = function makeSchema(plotlyPath, schemaPath) { | |||
| // package is annoying and platform-dependent. | |||
| // see https://github.com/tmpvar/jsdom/issues/1782 | |||
| w.HTMLCanvasElement.prototype.getContext = function() { return null; }; | |||
| w.URL.createObjectURL = function() { return null; }; | |||
There was a problem hiding this comment.
@etpinard npm run build works again with this change.
| // filter out data_array items that can contain user objects | ||
| // most of the time the toVal === fromVal check will catch these early | ||
| // but if the user makes new ones we also don't want to recurse in. | ||
| if(k === 'customdata' || k === 'ids') continue; |
There was a problem hiding this comment.
For reference, we should probably right down somewhere that values in the ids arrays should be strings.
But yeah, 👍 for being safe.
There was a problem hiding this comment.
For reference, we should probably right down somewhere that values in the
idsarrays should be strings.
I can put that in its attribute description, but is it important that these are strings and not numbers? Do they get converted to actual strings during use?
There was a problem hiding this comment.
Do they get converted to actual strings during use?
yep: cd[i].id = String(trace.ids[i]);
There was a problem hiding this comment.
I can put that in its attribute description
That would be great!
There was a problem hiding this comment.
comment added in 62e54b7
| var accesses = 0; | ||
|
|
||
| var obj = { | ||
| get _x() { accesses++; return 1; }, |
There was a problem hiding this comment.
Really, this is valid ES5?
There was a problem hiding this comment.
Yes, I believe so, though don't use it in src as it's not supported by IE or Safari. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get
There was a problem hiding this comment.
Oh actually I was reading the browser compatibility table wrong... in fact looks like this basic setter/getter usage is fine even in IE and Safari, though I still feel like we should avoid it as it can make things confusing. I've only ever used it for testing and debugging. If, for example, a property gets set but you can't figure out where it's getting set, attach a setter for that property that throws an error.
|
Looking great 💃 |
@etpinard a quick change to improve update performance with complicated
customdata