Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZERO circular dependency #2429

Merged
merged 17 commits into from
Mar 2, 2018
Merged

ZERO circular dependency #2429

merged 17 commits into from
Mar 2, 2018

Commits on Mar 1, 2018

  1. move grid module to components/ 

    ... so that its attributes are added to the schema
    free of circular deps.
    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    bee37dd View commit details
    Browse the repository at this point in the history

  2. merge src/plot_api/register.js into src/registry.js 

    - no need to have a separate method just for the top-level
  method.
    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    973abbc View commit details
    Browse the repository at this point in the history

  3. fixes #621 - make x/y/z dependent error bar attributes 

    ... by using utilizing component-to-schema logic,
    instead of punching the error bar attributes into
    the trace declarations.
    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    b08c402 View commit details
    Browse the repository at this point in the history

  4. use errorbars methods via getComponentMethod 

    ... so that down the road errorbars could be taken out
    or src/core.js, and be its own registrable module.
    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    87275af View commit details
    Browse the repository at this point in the history

  5. add apiMethodRegistry in src/registry 

    - export api methods in plot_api/index.js
- expose and register them in src/core.js
    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    52b83b3 View commit details
    Browse the repository at this point in the history

  6. add Registry.call method + use it to 馃敧 circular deps !!!

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    9fc8832 View commit details
    Browse the repository at this point in the history

  7. move Plotly.setPlotConfig to plot_api.js

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    381b6e4 View commit details
    Browse the repository at this point in the history

  8. use Registry.traceIs instead of plots.traceIs copy

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    ed8d56d View commit details
    Browse the repository at this point in the history

  9. 馃敧 src/plotly.js !!!

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    204799c View commit details
    Browse the repository at this point in the history

  10. 馃敀 down circular dep test at 0锔忊儯

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    2c529ec View commit details
    Browse the repository at this point in the history

  11. update tests (mostly update ref to spyOn modules)

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c6df699 View commit details
    Browse the repository at this point in the history

  12. add flaky tag to scattergl visible toggle test

    @etpinard
    etpinard committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    011443e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. grab Grid module method using Registry.getComponentMethod

    @etpinard
    etpinard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    9246fda View commit details
    Browse the repository at this point in the history

  2. fix typo in test_syntax

    @etpinard
    etpinard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    d27b3ba View commit details
    Browse the repository at this point in the history

  3. rename register_test -> registry_test & improve it! 

    - move all spec under top-level describe(),
  so that they can easily reuse the 'unregister' wrapper,
- fixup spec naming
    @etpinard
    etpinard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    e05f4f0 View commit details
    Browse the repository at this point in the history

  4. replace Registry.call('', []) with Registry.call('', ...[]) 

    ... everywhere except for plots/command.js where
    and fn.apply would work better, for now just
    grab api method for registry cache.
    @etpinard
    etpinard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    705aed6 View commit details
    Browse the repository at this point in the history

  5. no need for Registry in plot_api/to_image 

    ... and 'enforce' Registry in components/modebar/
    (like for all components really).
    @etpinard
    etpinard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    a851aa5 View commit details
    Browse the repository at this point in the history