-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splom zoom perf #2527
Merged
Merged
Splom zoom perf #2527
Commits on Apr 5, 2018
-
move doAutoRangeAndConstraints, drawData and finalDraw to subroutines
... (i.e. out of plot_api.js), and move Plots.addLinks out of drawData into its own step in Plotly.plot.
Configuration menu - View commit details
-
Copy full SHA for 02ed2eb - Browse repository at this point
Copy the full SHA 02ed2ebView commit details -
- this represents the minimal sequence for '(x|y)axis.range' relayout calls which are pretty common (e.g. on zoom/pan mouseup). - by bypassing drawFramework, lsInner and initInteraction, this can save ~1000ms on 50x50 subplot grids.
Configuration menu - View commit details
-
Copy full SHA for 3ad1eaa - Browse repository at this point
Copy the full SHA 3ad1eaaView commit details -
speed up doModeBar subroutines for cartesian subplots
- split minimal updateFx part out of initInteractions - set maindrag cursor class (which depends only on layout.dragmode) on <g .draglayer> instead of inner <rect> to update it for all subplots in < 1ms (that's a > 600ms improvement on 50x50 grids) - use gd._fullLayout instead of scoped fullLayout in initInteractions and makeDragBox to ensure correct reference after doModeBar()
Configuration menu - View commit details
-
Copy full SHA for bb02281 - Browse repository at this point
Copy the full SHA bb02281View commit details -
- allow fullLayout._has(/*trace type*/) to work - use registry category hash object (instead of categories.indexOf) to find categories in fullLayout._modules
Configuration menu - View commit details
-
Copy full SHA for d07ae70 - Browse repository at this point
Copy the full SHA d07ae70View commit details -
- replace indexOf with hash objects lookups - add 'svg' and 'draggedPts' trace module categories - speed up updateSubplots (called on pan and scroll) by splitting it into splom, scattergl, svg and draggedPts blocks, (draggedPts is very slow, svg can be slow at 50x50) - ... some scope variable clean up
Configuration menu - View commit details
-
Copy full SHA for 468119e - Browse repository at this point
Copy the full SHA 468119eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0979272 - Browse repository at this point
Copy the full SHA 0979272View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebb35ce - Browse repository at this point
Copy the full SHA ebb35ceView commit details
Commits on Apr 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f9090b7 - Browse repository at this point
Copy the full SHA f9090b7View commit details
Commits on Apr 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b2ee736 - Browse repository at this point
Copy the full SHA b2ee736View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b2574 - Browse repository at this point
Copy the full SHA a0b2574View commit details
Commits on Apr 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d3fe40d - Browse repository at this point
Copy the full SHA d3fe40dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc1b3de - Browse repository at this point
Copy the full SHA cc1b3deView commit details
Commits on Apr 11, 2018
-
Merge branch 'splom-feature' into splom-zoom-perf
(to get tests to pass)
Configuration menu - View commit details
-
Copy full SHA for 980855c - Browse repository at this point
Copy the full SHA 980855cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7d637d - Browse repository at this point
Copy the full SHA f7d637dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.