Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splom zoom perf #2527

Merged
merged 14 commits into from
Apr 11, 2018
Merged

Splom zoom perf #2527

merged 14 commits into from
Apr 11, 2018

Commits on Apr 5, 2018

  1. move doAutoRangeAndConstraints, drawData and finalDraw to subroutines

    ... (i.e. out of plot_api.js),
        and move Plots.addLinks out of drawData into its own
        step in Plotly.plot.
    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    02ed2eb View commit details
    Browse the repository at this point in the history
  2. add 'axrange' editType

    - this represents the minimal sequence for '(x|y)axis.range'
      relayout calls which are pretty common (e.g. on zoom/pan
      mouseup).
    - by bypassing drawFramework, lsInner and initInteraction,
      this can save ~1000ms on 50x50 subplot grids.
    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    3ad1eaa View commit details
    Browse the repository at this point in the history
  3. speed up doModeBar subroutines for cartesian subplots

    - split minimal updateFx part out of initInteractions
    - set maindrag cursor class (which depends only on layout.dragmode)
      on <g .draglayer> instead of inner <rect> to update it for
      all subplots in < 1ms (that's a > 600ms improvement on 50x50 grids)
    - use gd._fullLayout instead of scoped fullLayout in initInteractions
      and makeDragBox to ensure correct reference after doModeBar()
    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    bb02281 View commit details
    Browse the repository at this point in the history
  4. improve fullLayout._has()

    - allow fullLayout._has(/*trace type*/) to work
    - use registry category hash object (instead of categories.indexOf)
      to find categories in fullLayout._modules
    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    d07ae70 View commit details
    Browse the repository at this point in the history
  5. speed up dragbox

    - replace indexOf with hash objects lookups
    - add 'svg' and 'draggedPts' trace module categories
    - speed up updateSubplots (called on pan and scroll) by
      splitting it into splom, scattergl, svg and draggedPts blocks,
      (draggedPts is very slow, svg can be slow at 50x50)
    - ... some scope variable clean up
    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    468119e View commit details
    Browse the repository at this point in the history
  6. clean splom drag logic

    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    0979272 View commit details
    Browse the repository at this point in the history
  7. lint in plot_api

    etpinard committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    ebb35ce View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    f9090b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Configuration menu
    Copy the full SHA
    b2ee736 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0b2574 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2018

  1. Configuration menu
    Copy the full SHA
    d3fe40d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc1b3de View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. Merge branch 'splom-feature' into splom-zoom-perf

    (to get tests to pass)
    etpinard committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    980855c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7d637d View commit details
    Browse the repository at this point in the history