New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed size shapes #2532
Merged
Merged
Fixed size shapes #2532
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dc2f3ba
Move assertions from hover_label_test.js to custom_assertions.js #2193
rmoestl 49f7fb0
Enhance documentation of autorange.js `expand` function
rmoestl d386b2d
Introduce fixed size shapes #2193
rmoestl c2203fa
Rename 'data' to 'scaled' for size mode attrs of fixed size shapes #2193
rmoestl ce9691c
Add an image test for fixed size shapes #2193
rmoestl 502aa6a
Add missing trailing new line char in fixed_size_shapes.json mock #2193
rmoestl 3bf6abb
Add log, date and categorical axes to fixed_size_shapes mock #2193
rmoestl eb853ab
Fix drag cursor bug for shapes
rmoestl File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,255 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "x": [1,4], | ||
| "y": [1,4] | ||
| }, { | ||
| "x": [1,4], | ||
| "y": [1,5], | ||
| "xaxis": "x2", | ||
| "yaxis": "y2" | ||
| }, { | ||
| "x": [1,4], | ||
| "y": [1,5], | ||
| "xaxis": "x3", | ||
| "yaxis": "y3" | ||
| }, { | ||
| "x": [1,4], | ||
| "y": [1,5], | ||
| "xaxis": "x4", | ||
| "yaxis": "y4" | ||
| } | ||
| ], | ||
| "layout": { | ||
| "title": "Fixed size shapes", | ||
| "autosize": false, | ||
| "width": 1000, | ||
| "height": 800, | ||
| "xaxis": { | ||
| "domain": [0,0.30], | ||
| "anchor": "y", | ||
| "title": "rect, circle, line" | ||
| }, | ||
| "yaxis": { | ||
| "domain": [0.55,1], | ||
| "type": "linear", | ||
| "anchor": "x" | ||
| }, | ||
| "xaxis2": { | ||
| "domain":[0.33,0.66], | ||
| "anchor": "y2", | ||
| "title": "triangle as path" | ||
| }, | ||
| "yaxis2": { | ||
| "domain": [0.55,1], | ||
| "type": "linear", | ||
| "anchor": "x2" | ||
| }, | ||
| "xaxis3": { | ||
| "domain":[0.70,1], | ||
| "anchor": "y3", | ||
| "title": "drag / resize for auto-range" | ||
| }, | ||
| "yaxis3": { | ||
| "domain": [0.55,1], | ||
| "type": "linear", | ||
| "anchor": "x3" | ||
| }, | ||
| "xaxis4": { | ||
| "domain": [0,0.30], | ||
| "anchor": "y4", | ||
| "title": "xy pos & x size paper, y size pixel" | ||
| }, | ||
| "yaxis4": { | ||
| "domain": [0,0.45], | ||
| "type": "linear", | ||
| "anchor": "x4" | ||
| }, | ||
| "xaxis5": { | ||
| "domain":[0.33,0.66], | ||
| "anchor": "y5", | ||
| "title": "rects w/ mixed size modes" | ||
| }, | ||
| "yaxis5": { | ||
| "domain": [0,0.45], | ||
| "type": "linear", | ||
| "anchor": "x5" | ||
| }, | ||
| "xaxis6": { | ||
| "domain":[0.70,1], | ||
| "anchor": "y6", | ||
| "title": "paths w/ mixed size modes" | ||
| }, | ||
| "yaxis6": { | ||
| "domain": [0,0.45], | ||
| "type": "linear", | ||
| "anchor": "x6" | ||
| }, | ||
| "shapes": [ | ||
| { | ||
| "type": "circle", | ||
| "xref": "x", | ||
| "xsizemode": "pixel", | ||
| "yref": "y", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 8, | ||
| "yanchor": 8, | ||
| "x0": -20, | ||
| "x1": 20, | ||
| "y0": 20, | ||
| "y1": -20, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "rect", | ||
| "xref": "x", | ||
| "xsizemode": "pixel", | ||
| "yref": "y", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 7, | ||
| "yanchor": 8, | ||
| "x0": -20, | ||
| "x1": 20, | ||
| "y0": 20, | ||
| "y1": -20, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "line", | ||
| "xref": "x", | ||
| "xsizemode": "pixel", | ||
| "yref": "y", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 6, | ||
| "yanchor": -3, | ||
| "x0": -20, | ||
| "x1": 60, | ||
| "y0": 0, | ||
| "y1": 40, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "path", | ||
| "xref": "x2", | ||
| "xsizemode": "pixel", | ||
| "yref": "y2", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": -1, | ||
| "yanchor": 10, | ||
| "path": "M0,0 L30,0 L15,15 Z", | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "rect", | ||
| "xref": "x3", | ||
| "xsizemode": "pixel", | ||
| "yref": "y3", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 2, | ||
| "yanchor": 2, | ||
| "x0": 3, | ||
| "x1": 53, | ||
| "y0": 20, | ||
| "y1": -20, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "rect", | ||
| "xref": "paper", | ||
| "xsizemode": "scaled", | ||
| "yref": "paper", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 0, | ||
| "yanchor": 0, | ||
| "x0": 0, | ||
| "x1": 0.3, | ||
| "y0": 10, | ||
| "y1": -10, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "rect", | ||
| "xref": "x5", | ||
| "xsizemode": "scaled", | ||
| "yref": "y5", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 0, | ||
| "yanchor": 10, | ||
| "x0": 0, | ||
| "x1": 10, | ||
| "y0": 0, | ||
| "y1": -30, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "rect", | ||
| "xref": "x5", | ||
| "xsizemode": "pixel", | ||
| "yref": "y5", | ||
| "ysizemode": "scaled", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 3, | ||
| "yanchor": 3, | ||
| "x0": 0, | ||
| "x1": 30, | ||
| "y0": 0, | ||
| "y1": 10, | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "path", | ||
| "xref": "x6", | ||
| "xsizemode": "pixel", | ||
| "yref": "y6", | ||
| "ysizemode": "scaled", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 10, | ||
| "yanchor": 10, | ||
| "path": "M0,0 L30,0 L15,4 Z", | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| }, | ||
| { | ||
| "type": "path", | ||
| "xref": "x6", | ||
| "xsizemode": "scaled", | ||
| "yref": "y6", | ||
| "ysizemode": "pixel", | ||
| "fillcolor": "rgba(96, 171, 50,0.7)", | ||
| "xanchor": 10, | ||
| "yanchor": 10, | ||
| "path": "M0,0 L10,0 L5,25 Z", | ||
| "line": { | ||
| "color": "rgba(96, 171, 50, 1)" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "config": { | ||
| "editable": "true" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice test image, and I think the interactions feel very natural as you have them. Other than adding a trailing newline to make the syntax test happy the only change I'd like to see is to use the other three axis types (log, date, category) on one axis each - no need to add more subplots, just convert a couple of the existing axes.