Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isArrayOrTypedArray in gl_format_color.js #2596

Merged
merged 1 commit into from
May 1, 2018

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented May 1, 2018

fixes #2591 - one Array.isArray -> Lib.isArrayOrTypedArray that slipped through in #2388

cc @alexcjohnson @dy

@etpinard etpinard added bug something broken status: reviewable labels May 1, 2018
@alexcjohnson
Copy link
Collaborator

Nice and easy - 💃

No guarantee there aren't others lingering out there... I wonder if we can do something perhaps in the react-noop tests like crawl each figure for numeric arrays, convert them all to typed arrays, and verify that nothing fails? I guess that wouldn't have caught this one though, as it didn't cause an error, just failed to use the array, and it doesn't seem like there's any generic way to tell that other than I guess image tests...

Or we can just let @jmmease tell us what else we missed 😉

@etpinard
Copy link
Contributor Author

etpinard commented May 1, 2018

Or we can just let @jmmease tell us what else we missed

This gets my vote 😄

Or this #913 or probably the best solution from #1784 (comment)

@etpinard etpinard merged commit a22c0d5 into master May 1, 2018
@etpinard etpinard deleted the gl-format-typed-array-colors branch May 1, 2018 17:23
@jonmmease
Copy link
Contributor

Works for me 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scattergl marker color behaves unexpectedly when specified as TypedArray
3 participants