fix #2598 - sloppy click on cartesian zoom #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and they shouldn't - it's the mouseDown and mouseMove events that actually matter to the action. So update the test to reflect that.
etpinard
reviewed
May 22, 2018
| else zoomMode = (ew ? 'x' : '') + (ns ? 'y' : ''); | ||
|
|
||
| dragTail(zoomMode); | ||
| dragTail(); |
There was a problem hiding this comment.
Nice catch, dragTail no longer takes arguments after 5b6a1fa
etpinard
reviewed
May 22, 2018
| @@ -266,6 +269,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) { | |||
| path0 = 'M0,0H' + pw + 'V' + ph + 'H0V0'; | |||
| dimmed = false; | |||
| zoomMode = 'xy'; | |||
| zoomDragged = false; | |||
etpinard
reviewed
May 22, 2018
| @@ -341,6 +345,9 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) { | |||
| box.w = box.r - box.l; | |||
| box.h = box.b - box.t; | |||
|
|
|||
| if(zoomMode) zoomDragged = true; | |||
| gd._dragged = zoomDragged; | |||
There was a problem hiding this comment.
and this one move in zoomMove
etpinard
reviewed
May 22, 2018
|
|
||
| mouseEvent('mousemove', x, y, moveOpts); | ||
| mouseEvent('mousedown', x, y, downOpts); | ||
| if(callContext) mouseEvent('contextmenu', x, y, downOpts); | ||
| if(slopX || slopY) mouseEvent('mousemove', x + slopX, y + slopY, slopOpts); |
There was a problem hiding this comment.
So, slop is only used for testing? This is fine, but perhaps we could add a comment about this in the jsDoc above so that we don't feel like 🔪 down the road.
There was a problem hiding this comment.
sure -> c56f223
|
Thanks! Looks good 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in a comment, zoom takes over
minDrag, so it also has to take overgd._draggedAlso removed a little obsolete behavior while I was at it.
cc @etpinard