Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select <-> pan double-click behavior #2668

Merged
merged 3 commits into from May 25, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Copy link
Member

commented May 25, 2018

Commit 20820cb fixes #2667 which has been broken since bb02281 (from one of the splom perf PRs) where drag handlers are no-longer reintialized when relayout'ing dragmode.

cc @alexcjohnson

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented May 25, 2018

Good catch! 💃

@etpinard etpinard merged commit b042f93 into master May 25, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the fix-select-pan-clickfn-swap branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.