Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix size and alignment of vertical modebar to match horizontal modebar #3193

Merged
merged 1 commit into from Oct 31, 2018
Merged

fix size and alignment of vertical modebar to match horizontal modebar #3193

merged 1 commit into from Oct 31, 2018

Conversation

antoinerg
Copy link
Contributor

@antoinerg antoinerg commented Oct 31, 2018 •
edited

Fixes issue #3189

The two issues to fix were:

  • vertical modebar protrude outside the parent container
  • vertical modebar use all the space available even when it doesn't need it

@antoinerg
Copy link
Contributor Author

Here's a Codepen to test the changes: https://codepen.io/plotly/pen/mzZgvo

Please make sure it looks good on your OS/browser. In particular @alexcjohnson since it looked different on your setup 🤔

@alexcjohnson
Copy link
Contributor

Beautiful. 💃 for my part

@etpinard
Copy link
Contributor

Looks good 💃

@antoinerg antoinerg merged commit 6fda595 into master Oct 31, 2018
@antoinerg antoinerg deleted the 3189-vertical-modebar branch October 31, 2018 18:06
@etpinard etpinard mentioned this pull request Nov 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoinerg @alexcjohnson @etpinard