implement watermark config option #3280
Conversation
| @@ -5,12 +5,12 @@ | |||
| z-index: 1001; | |||
| } | |||
|
|
|||
| .modebar--hover { | |||
| .modebar--hover > :not(.watermark) { | |||
There was a problem hiding this comment.
Apparently :not is supported IE9+: https://caniuse.com/#search=%3Anot
There was a problem hiding this comment.
CSS child selector should also work in IE9+. The reason we use it is because we cannot override the opacity of a child if the parent has a CSS opacity.
There was a problem hiding this comment.
Nice find. But we should test this out in IE9 and IE11 (from browserstack) before merging this thing.
There was a problem hiding this comment.
Works in IE11:
IE9/10 doesn't work on master 😐
I will open an issue for the latter.
There was a problem hiding this comment.
Oh wait, right the main plotly.js bundle doesn't work in ie9.
You'll need to use plotly-basic.js:
There was a problem hiding this comment.
Works in IE9 🎉
About using plotly-basic.js in IE9 versus plotly.js: is this documented somewhere? If not I should open an issue over at the documentation project.
There was a problem hiding this comment.
More precisely, all SVG-based traces should work in IE9.
We could maybe add some info here ->
https://github.com/plotly/plotly.js/tree/master/dist#to-support-ie9
| @@ -133,6 +133,9 @@ module.exports = { | |||
| // add the plotly logo on the end of the mode bar | |||
| displaylogo: true, | |||
|
|
|||
| // watermark the images with the company's logo | |||
| watermark: false, | |||
There was a problem hiding this comment.
Yesss! false by default 👌
|
Looking good! It should be possible to add the a few test cases in https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/modebar_test.js to 🔒 down the new |
|
💃 nicely done. |
Closes #3268 exactly as described/requested by @nicolaskruchten's in his first comment #3268 (comment)