Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fills on segment-less marker-less traces #3282

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

etpinard
Copy link
Contributor

fixes #3277 - introduced by 1f3c10c

cc @plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Sure, I was going to suggest deleting the element so we don't need to trust as much that we always set the data, but since it's a singleton element that would be awkward. So, looks good. 💃

@etpinard
Copy link
Contributor Author

but since it's a singleton element that would be awkward

My thoughts exactly.

@etpinard etpinard merged commit ed9ad69 into master Nov 27, 2018
@etpinard etpinard deleted the fix-segment-marker-less-fills branch November 27, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill tozeroy with a null filled y array errors out
2 participants