Bump scatter2d entry on regl-splom and fix for scattergl with multiple colors #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. Can we test that and gl-vis/regl-scatter2d#15 together? |
|
Why is this a regression? |
|
#3232 was a regression. |
|
Great. Tests are passing on my machine too! |
|
@archmoj this seems like the appropriate base branch to get gl-vis/regl-splom#10 and gl-vis/regl-scatter2d#15 into plotly.js. Would you mind (1) adding a test mock that locks down #3232 (2) close #3315 and #3242 |
|
OK. |
This was referenced Dec 12, 2018
archmoj
commented
Dec 13, 2018
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/regl-scatter2d/-/regl-scatter2d-3.0.6.tgz", | ||
| "integrity": "sha512-l2/OcCRKTxsCtrGtb2TKUKYnDHzI07qOm2eK2kiRYKyDwiWiGyiLC6p3SlOxDoqhQ/8gbIue9BABPXuCJ0lpRQ==", | ||
| "version": "git://github.com/gl-vis/regl-scatter2d.git#4b5a08f5c18616055f3f630a1b1592f2a681da0f", | ||
| "from": "git://github.com/gl-vis/regl-scatter2d.git#4b5a08f5c18616055f3f630a1b1592f2a681da0f", |
There was a problem hiding this comment.
archmoj
commented
Dec 13, 2018
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/regl-splom/-/regl-splom-1.0.4.tgz", | ||
| "integrity": "sha512-+iq/RJAJdHCp48wPbEGQ5qw29OXFVF/m7CzcuLZxwptjdkB/FHGKiMuyqclOSNQcEKFxQTvRRJMJJ6brd8VvrA==", | ||
| "version": "git://github.com/gl-vis/regl-splom.git#17ec1b340fd7db810f5efe20516e8fbf11331c61", | ||
| "from": "git://github.com/gl-vis/regl-splom.git#17ec1b340fd7db810f5efe20516e8fbf11331c61", |
There was a problem hiding this comment.
|
@archmoj you can use real npm versions, I've published the two packages. |
|
Many thanks @dy. Just applied the changes using release versions. |
archmoj
changed the title
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @dy noticed
regl-splomuses wrongregl-scatter2dentry, pointing to not a bundle.This branch tested with CI the changes of the regl-splom PR.
Also #3232 & https://github.com/plotly/phoenix-integration/issues/232 would be fixed in regards with regl-scatter2d PR.
@etpinard