Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3339 - typed arrays support for ohlc / candlestick traces #3342

Merged
merged 1 commit into from
Dec 17, 2018
Merged

fix #3339 - typed arrays support for ohlc / candlestick traces #3342

merged 1 commit into from
Dec 17, 2018

Conversation

etpinard
Copy link
Contributor

cc @plotly/plotly_js - easy fix before we tackle #3215 (which would be a nice holiday project 馃 )

@antoinerg
Copy link
Contributor

antoinerg commented Dec 17, 2018 •
edited
Loading

@etpinard I wasn't aware that TypedArray were supported in Plotly.js and I am now wondering if we're using Float32Array everywhere. I think it would be useful to be able to specify the array type. For example, most scientific computing is done using double precision floating for which Float64Array is more appropriate.

@antoinerg
Copy link
Contributor

Nice tests! Looks good to me 馃拑

@etpinard
Copy link
Contributor Author

For more info on future typed array development (including setting type in JSON) -> #1784

@etpinard etpinard merged commit fdafdb9 into master Dec 17, 2018
@etpinard etpinard deleted the finance-typed-arrays branch December 17, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etpinard @antoinerg