Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt contour label clipPath segments for reversed axes #3352

Merged
merged 2 commits into from Dec 21, 2018
Merged

Adapt contour label clipPath segments for reversed axes #3352

merged 2 commits into from Dec 21, 2018

Conversation

etpinard
Copy link
Contributor

fixes #3349 , this PR is a follow-up on #3293 - #3293 made:

This fix is easy. We just had to make sure the first clipPath polygon got drawn counterclockwise.

@etpinard
adapt contour label clipPath segments for reversed axes
17e7823 
- it needs to have correct direction so that the SVG even-odd
  fill rule works.
archmoj
archmoj reviewed Dec 20, 2018
View reviewed changes
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thanks @etpinard.
I only have one comment related to the mock.

test/image/mocks/contour_label-reversed-axes.json Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Dec 21, 2018

💃

@etpinard etpinard merged commit 0078626 into master Dec 21, 2018
@etpinard etpinard deleted the one-more-contour-label-reversed-ax-fix branch December 21, 2018 14:24
@etpinard etpinard mentioned this pull request Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj left review comments

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contour Axis in "reverse" causes the line underneath the label to show up
2 participants
@etpinard @archmoj