Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New eslint rules #3374

Merged
merged 3 commits into from
Dec 26, 2018
Merged

New eslint rules #3374

merged 3 commits into from
Dec 26, 2018

Conversation

etpinard
Copy link
Contributor

from #3162, this PR adds camelcase and one-var rule.

@etpinard
Copy link
Contributor Author

As this PR is just 3000+ lines of linting, I'll go ahead of merge this to avoid conflict in new branches.

I hope @plotly/plotly_js won't mind.

@etpinard etpinard merged commit a56fa2a into master Dec 26, 2018
@etpinard etpinard deleted the new-eslint-rules branch December 26, 2018 15:42
@antoinerg antoinerg mentioned this pull request Dec 26, 2018
@archmoj
Copy link
Contributor

archmoj commented Dec 26, 2018

Great!

@alexcjohnson
Copy link
Collaborator

Taking advantage of the holiday lull, very nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants